Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap httr out for httr2 #25

Merged
merged 11 commits into from
Aug 15, 2024
Merged

Swap httr out for httr2 #25

merged 11 commits into from
Aug 15, 2024

Conversation

sckott
Copy link
Member

@sckott sckott commented Aug 9, 2024

Description

Removed the http client httr and now are using httr2 throughout the package.

Reason for this is that httr has entered a stage where they're not really working on the package anymore, and shifting focus to httr2. Had to wait a bit to do this until webmockr supported httr2 (only used in tests, but still important)

Related Issue

fixes #3

Example

run any fxn in the package ...

Testing

  • Tests in this package are passing locally and on CI
  • Ran the proof shiny app with this package and it works smoothly

@sckott sckott added the enhancement New feature or request label Aug 9, 2024
@sckott sckott added this to the proofr v0.2.2 milestone Aug 9, 2024
@sckott sckott requested a review from seankross August 9, 2024 16:45
R/auth.R Show resolved Hide resolved
@seankross
Copy link
Contributor

LGTM except: #25 (comment)

@sckott
Copy link
Member Author

sckott commented Aug 15, 2024

thanks

@sckott sckott merged commit 5de3e90 into dev Aug 15, 2024
5 checks passed
@sckott sckott deleted the httr2-webmockr branch August 15, 2024 23:04
@tefirman tefirman mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants